Fix: #3924 by preventing an undefined schema for fixed array items #3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
heath-freenome
force-pushed
the
fix-3924
branch
2 times, most recently
from
2c76fc1
to
ecf1567
Compare
… items Fixes rjsf-team#3924 by defaulting to an empty object for the `itemSchema` when undefined Fixes rjsf-team#3927 by fixing `getSnapshotBeforeUpdate()` added for the fix rjsf-team#1794 - In `@rjsf/core` updated `ArrayField`'s `renderFixedArray()` to default the `itemSchema` to an empty object if it is falsy - Updated the tests for `ArrayField` to verify the fix - Updated the `getSnapshotBeforeUpdate()` to diff the old and new props and to set the `shouldUpdate` prop if the old and new state differs - Updated `CHANGELOG.md` accordingly - Also added entry for the fix for rjsf-team#3919
heath-freenome
force-pushed
the
fix-3924
branch
from
ecf1567
to
20cec3c
Compare
nickgros
approved these changes
Oct 30, 2023
| ): { nextState: FormState<T, S, F>; shouldUpdate: true } | { shouldUpdate: false } { | ||
| if (!deepEquals(this.props.formData, prevProps.formData)) { | ||
| if (!deepEquals(this.props, prevProps)) { |
There was a problem hiding this comment.
Thanks for finding and fixing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #3924 by defaulting to an empty object for the
itemSchemawhen undefinedFixes #3927 by fixing
getSnapshotBeforeUpdate()added for the fix #1794@rjsf/coreupdatedArrayField'srenderFixedArray()to default theitemSchemato an empty object if it is falsyArrayFieldto verify the fixgetSnapshotBeforeUpdate()to diff the old and new props and to set theshouldUpdateprop if the old and new state differsCHANGELOG.mdaccordinglyChecklist
npm run test:updateto update snapshots, if needed.